• Michael Paquier's avatar
    Restrict access to reindex of shared catalogs for non-privileged users · 661dd239
    Michael Paquier authored
    A database owner running a database-level REINDEX has the possibility to
    also do the operation on shared system catalogs without being an owner
    of them, which allows him to block resources it should not have access
    to.  The same goes for a schema owner.  For example, PostgreSQL would go
    unresponsive and even block authentication if a lock is waited for
    pg_authid.  This commit makes sure that a user running a REINDEX SYSTEM,
    DATABASE or SCHEMA only works on the following relations:
    - The user is a superuser
    - The user is the table owner
    - The user is the database/schema owner, only if the relation worked on
    is not shared.
    
    Robert has worded most the documentation changes, and I have coded the
    core part.
    
    Reported-by: Lloyd Albin, Jeremy Schneider
    Author: Michael Paquier, Robert Haas
    Reviewed by: Nathan Bossart, Kyotaro Horiguchi
    Discussion: https://postgr.es/m/152512087100.19803.12733865831237526317@wrigleys.postgresql.org
    Discussion: https://postgr.es/m/20180805211059.GA2185@paquier.xyz
    Backpatch-through: 11- as the current behavior has been around for a
    very long time and could be disruptive for already released branches.
    661dd239
indexcmds.c 80.8 KB