• Tom Lane's avatar
    Restructure index access method API to hide most of it at the C level. · 65c5fcd3
    Tom Lane authored
    This patch reduces pg_am to just two columns, a name and a handler
    function.  All the data formerly obtained from pg_am is now provided
    in a C struct returned by the handler function.  This is similar to
    the designs we've adopted for FDWs and tablesample methods.  There
    are multiple advantages.  For one, the index AM's support functions
    are now simple C functions, making them faster to call and much less
    error-prone, since the C compiler can now check function signatures.
    For another, this will make it far more practical to define index access
    methods in installable extensions.
    
    A disadvantage is that SQL-level code can no longer see attributes
    of index AMs; in particular, some of the crosschecks in the opr_sanity
    regression test are no longer possible from SQL.  We've addressed that
    by adding a facility for the index AM to perform such checks instead.
    (Much more could be done in that line, but for now we're content if the
    amvalidate functions more or less replace what opr_sanity used to do.)
    We might also want to expose some sort of reporting functionality, but
    this patch doesn't do that.
    
    Alexander Korotkov, reviewed by Petr Jelínek, and rather heavily
    editorialized on by me.
    65c5fcd3
spgscan.c 16.4 KB