• Tom Lane's avatar
    Don't try to print data type names in slot_store_error_callback(). · 63a95216
    Tom Lane authored
    The existing code tried to do syscache lookups in an already-failed
    transaction, which is problematic to say the least.  After some
    consideration of alternatives, the best fix seems to be to just drop
    type names from the error message altogether.  The table and column
    names seem like sufficient localization.  If the user is unsure what
    types are involved, she can check the local and remote table
    definitions.
    
    Having done that, we can also discard the LogicalRepTypMap hash
    table, which had no other use.  Arguably, LOGICAL_REP_MSG_TYPE
    replication messages are now obsolete as well; but we should
    probably keep them in case some other use emerges.  (The complexity
    of removing something from the replication protocol would likely
    outweigh any savings anyhow.)
    
    Masahiko Sawada and Bharath Rupireddy, per complaint from Andres
    Freund.  Back-patch to v10 where this code originated.
    
    Discussion: https://postgr.es/m/20210106020229.ne5xnuu6wlondjpe@alap3.anarazel.de
    63a95216
relation.c 16.7 KB