• Tom Lane's avatar
    Avoid platform-specific null pointer dereference in psql. · 6338fa3e
    Tom Lane authored
    POSIX permits getopt() to advance optind beyond argc when the last
    argv entry is an option that requires an argument and hasn't got one.
    It seems that no major platforms actually do that, but musl does,
    so that something like "psql -f" would crash with that libc.
    Add a check that optind is in range before trying to look at the
    possibly-bogus option.
    
    Report and fix by Quentin Rameau.  Back-patch to all supported
    branches.
    
    Discussion: https://postgr.es/m/20190825100617.GA6087@fifth.space
    6338fa3e
startup.c 28.7 KB