• Tom Lane's avatar
    Further fix for psql's code for locale-aware formatting of numeric output. · 6325527d
    Tom Lane authored
    On closer inspection, those seemingly redundant atoi() calls were not so
    much inefficient as just plain wrong: the author of this code either had
    not read, or had not understood, the POSIX specification for localeconv().
    The grouping field is *not* a textual digit string but separate integers
    encoded as chars.
    
    We'll follow the existing code as well as the backend's cash.c in only
    honoring the first group width, but let's at least honor it correctly.
    
    This doesn't actually result in any behavioral change in any of the
    locales I have installed on my Linux box, which may explain why nobody's
    complained; grouping width 3 is close enough to universal that it's barely
    worth considering other cases.  Still, wrong is wrong, so back-patch.
    6325527d
print.c 76.2 KB