• Andres Freund's avatar
    Define integer limits independently from the system definitions. · 62e2a8dc
    Andres Freund authored
    In 83ff1618 we defined integer limits iff they're not provided by the
    system. That turns out not to be the greatest idea because there's
    different ways some datatypes can be represented. E.g. on OSX PG's 64bit
    datatype will be a 'long int', but OSX unconditionally uses 'long
    long'. That disparity then can lead to warnings, e.g. around printf
    formats.
    
    One way to fix that would be to back int64 using stdint.h's
    int64_t. While a good idea it's not that easy to implement. We would
    e.g. need to include stdint.h in our external headers, which we don't
    today. Also computing the correct int64 printf formats in that case is
    nontrivial.
    
    Instead simply prefix the integer limits with PG_ and define them
    unconditionally. I've adjusted all the references to them in code, but
    not the ones in comments; the latter seems unnecessary to me.
    
    Discussion: 20150331141423.GK4878@alap3.anarazel.de
    62e2a8dc
xlog.c 340 KB