• Tom Lane's avatar
    Fix corner-case errors in brin_doupdate(). · 62a16572
    Tom Lane authored
    In some cases the BRIN code releases lock on an index page, and later
    re-acquires lock and tries to check that the tuple it was working on is
    still there.  That check was a couple bricks shy of a load.  It didn't
    consider that the page might have turned into a "revmap" page.  (The
    samepage code path doesn't call brin_getinsertbuffer(), so it isn't
    protected by the checks for revmap status there.)  It also didn't check
    whether the tuple offset was now off the end of the linepointer array.
    Since commit 24992c6d the latter case is pretty common, but at least
    in principle it could have occurred before that.  The net result is
    that concurrent updates of a BRIN index could fail with errors like
    "invalid index offnum" or "inconsistent range map".
    
    Per report from Tomas Vondra.  Back-patch to 9.5, since this code is
    substantially the same in all versions containing BRIN.
    
    Discussion: https://postgr.es/m/10d2b9f9-f427-03b8-8ad9-6af4ecacbee9@2ndquadrant.com
    62a16572
brin_pageops.c 24.2 KB