• Tom Lane's avatar
    Allow user control of CTE materialization, and change the default behavior. · 608b167f
    Tom Lane authored
    Historically we've always materialized the full output of a CTE query,
    treating WITH as an optimization fence (so that, for example, restrictions
    from the outer query cannot be pushed into it).  This is appropriate when
    the CTE query is INSERT/UPDATE/DELETE, or is recursive; but when the CTE
    query is non-recursive and side-effect-free, there's no hazard of changing
    the query results by pushing restrictions down.
    
    Another argument for materialization is that it can avoid duplicate
    computation of an expensive WITH query --- but that only applies if
    the WITH query is called more than once in the outer query.  Even then
    it could still be a net loss, if each call has restrictions that
    would allow just a small part of the WITH query to be computed.
    
    Hence, let's change the behavior for WITH queries that are non-recursive
    and side-effect-free.  By default, we will inline them into the outer
    query (removing the optimization fence) if they are called just once.
    If they are called more than once, we will keep the old behavior by
    default, but the user can override this and force inlining by specifying
    NOT MATERIALIZED.  Lastly, the user can force the old behavior by
    specifying MATERIALIZED; this would mainly be useful when the query had
    deliberately been employing WITH as an optimization fence to prevent a
    poor choice of plan.
    
    Andreas Karlsson, Andrew Gierth, David Fetter
    
    Discussion: https://postgr.es/m/87sh48ffhb.fsf@news-spur.riddles.org.uk
    608b167f
postgres_fdw.out 427 KB