• Andres Freund's avatar
    Improve code around the recently added rm_identify rmgr callback. · 604f7956
    Andres Freund authored
    There are four weaknesses in728f152e:
    
    * append_init() in heapdesc.c was ugly and required that rm_identify
      return values are only valid till the next call. Instead just add a
      couple more switch() cases for the INIT_PAGE cases. Now the returned
      value will always be valid.
    * a couple rm_identify() callbacks missed masking xl_info with
      ~XLR_INFO_MASK.
    * pg_xlogdump didn't map a NULL rm_identify to UNKNOWN or a similar
      string.
    * append_init() was called when id=NULL - which should never actually
      happen. But it's better to be careful.
    604f7956
xlogdesc.c 4.38 KB