• Tom Lane's avatar
    Some code review for xml.c: · 5e512971
    Tom Lane authored
    Add some more xml_init() calls that might not be necessary, but seem like a
    good idea to avoid possible problems like we saw in xmlelement().
    Fix unsafe assumption that you can keep using the tupledesc of a relcache
    entry you don't have open.
    Add missing error checks for SearchSysCache failure.
    Get rid of handwritten array traversal in xpath() and O(N^2), broken-for-nulls
    array access code in map_sql_value_to_xml_value(), in favor of using
    deconstruct_array.
    Manually adjust a lot of line breaks in places where the code is otherwise
    gonna look pretty awful after pg_indent hacks it up (original author seems to
    have liked to lay out code for a 200-column window).
    5e512971
xml.c 81.2 KB