• Peter Geoghegan's avatar
    Avoid CREATE INDEX unique index deduplication. · 5da8bf8b
    Peter Geoghegan authored
    There is no advantage to attempting deduplication for a unique index
    during CREATE INDEX, since there cannot possibly be any duplicates.
    Doing so wastes cycles due to unnecessary copying.  Make sure that we
    avoid it consistently.
    
    We already avoided unique index deduplication in the case where there
    were some spool2 tuples to merge.  That didn't account for the fact that
    spool2 is removed early/unset in the common case where it has no tuples
    that need to be merged (i.e. it failed to account for the "spool2 turns
    out to be unnecessary" optimization in _bt_spools_heapscan()).
    
    Oversight in commit 0d861bbb, which added nbtree deduplication
    
    Backpatch: 13-, where nbtree deduplication was introduced.
    5da8bf8b
nbtsort.c 62.5 KB