• Tom Lane's avatar
    Rename SLRU structures and associated LWLocks. · 5da14938
    Tom Lane authored
    Originally, the names assigned to SLRUs had no purpose other than
    being shmem lookup keys, so not a lot of thought went into them.
    As of v13, though, we're exposing them in the pg_stat_slru view and
    the pg_stat_reset_slru function, so it seems advisable to take a bit
    more care.  Rename them to names based on the associated on-disk
    storage directories (which fortunately we *did* think about, to some
    extent; since those are also visible to DBAs, consistency seems like
    a good thing).  Also rename the associated LWLocks, since those names
    are likewise user-exposed now as wait event names.
    
    For the most part I only touched symbols used in the respective modules'
    SimpleLruInit() calls, not the names of other related objects.  This
    renaming could have been taken further, and maybe someday we will do so.
    But for now it seems undesirable to change the names of any globally
    visible functions or structs, so some inconsistency is unavoidable.
    
    (But I *did* terminate "oldserxid" with prejudice, as I found that
    name both unreadable and not descriptive of the SLRU's contents.)
    
    Table 27.12 needs re-alphabetization now, but I'll leave that till
    after the other LWLock renamings I have in mind.
    
    Discussion: https://postgr.es/m/28683.1589405363@sss.pgh.pa.us
    5da14938
lwlocknames.txt 1.46 KB