• Tom Lane's avatar
    Wrap appendrel member outputs in PlaceHolderVars in additional cases. · 57664ed2
    Tom Lane authored
    Add PlaceHolderVar wrappers as needed to make UNION ALL sub-select output
    expressions appear non-constant and distinct from each other.  This makes
    the world safe for add_child_rel_equivalences to do what it does.  Before,
    it was possible for that function to add identical expressions to different
    EquivalenceClasses, which logically should imply merging such ECs, which
    would be wrong; or to improperly add a constant to an EquivalenceClass,
    drastically changing its behavior.  Per report from Teodor Sigaev.
    
    The only currently known consequence of this bug is "MergeAppend child's
    targetlist doesn't match MergeAppend" planner failures in 9.1 and later.
    I am suspicious that there may be other failure modes that could affect
    older release branches; but in the absence of any hard evidence, I'll
    refrain from back-patching further than 9.1.
    57664ed2
planmain.c 15.1 KB