• Michael Paquier's avatar
    Block replication slot advance for these not yet reserving WAL · 56a71472
    Michael Paquier authored
    Such replication slots are physical slots freshly created without WAL
    being reserved, which is the default behavior, which have not been used
    yet as WAL consumption resources to retain WAL.  This prevents advancing
    a slot to a position older than any WAL available, which could falsify
    calculations for WAL segment recycling.
    
    This also cleans up a bit the code, as ReplicationSlotRelease() would be
    called on ERROR, and improves error messages.
    
    Reported-by: Kyotaro Horiguchi
    Author: Michael Paquier
    Reviewed-by: Andres Freund, Álvaro Herrera, Kyotaro Horiguchi
    Discussion: https://postgr.es/m/20180626071305.GH31353@paquier.xyz
    56a71472
catalogs.sgml 375 KB