• Tom Lane's avatar
    Fix assorted breakage in to_char()'s OF format option. · 55c3a04d
    Tom Lane authored
    In HEAD, fix incorrect field width for hours part of OF when tm_gmtoff is
    negative.  This was introduced by commit 2d87eedc as a result of
    falsely applying a pattern that's correct when + signs are omitted, which
    is not the case for OF.
    
    In 9.4, fix missing abs() call that allowed a sign to be attached to the
    minutes part of OF.  This was fixed in 9.5 by 9b43d73b, but for
    inscrutable reasons not back-patched.
    
    In all three versions, ensure that the sign of tm_gmtoff is correctly
    reported even when the GMT offset is less than 1 hour.
    
    Add regression tests, which evidently we desperately need here.
    
    Thomas Munro and Tom Lane, per report from David Fetter
    55c3a04d
timestamptz.sql 20.4 KB