• Tom Lane's avatar
    Prevent synchronized scanning when systable_beginscan chooses a heapscan. · 532fe28d
    Tom Lane authored
    The only interesting-for-performance case wherein we force heapscan here
    is when we're rebuilding the relcache init file, and the only such case
    that is likely to be examining a catalog big enough to be syncscanned is
    RelationBuildTupleDesc.  But the early-exit optimization in that code gets
    broken if we start the scan at a random place within the catalog, so that
    allowing syncscan is actually a big deoptimization if pg_attribute is large
    (at least for the normal case where the rows for core system catalogs have
    never been changed since initdb).  Hence, prevent syncscan here.  Per my
    testing pursuant to complaints from Jeff Frost and Greg Sabino Mullane,
    though neither of them seem to have actually hit this specific problem.
    
    Back-patch to 8.3, where syncscan was introduced.
    532fe28d
genam.c 14.4 KB