• Tom Lane's avatar
    Avoid a premature coercion failure in transformSetOperationTree() when · 52fc0075
    Tom Lane authored
    presented with an UNKNOWN-type Var, which can happen in cases where an
    unknown literal appeared in a subquery.  While many such cases will fail
    later on anyway in the planner, there are some cases where the planner is
    able to flatten the query and replace the Var by the constant before it has
    to coerce the union column to the final type.  I had added this check in 8.4
    to provide earlier/better error detection, but it causes a regression for
    some cases that worked OK before.  Fix by not making the check if the input
    node is UNKNOWN type and not a Const or Param.  If it isn't going to work,
    it will fail anyway at plan time, with the only real loss being inability to
    provide an error cursor.  Per gripe from Britt Piehler.
    
    In passing, rename a couple of variables to remove confusion from an
    inner scope masking the same variable names in an outer scope.
    52fc0075
union.out 8.37 KB