• Michael Paquier's avatar
    Improve and fix some error handling for REINDEX INDEX/TABLE CONCURRENTLY · 508300e2
    Michael Paquier authored
    This improves the user experience when it comes to restrict several
    flavors of REINDEX CONCURRENTLY.  First, for INDEX, remove a restriction
    on shared relations as we already check after catalog relations.  Then,
    for TABLE, add a proper error message when attempting to run the command
    on system catalogs.  The code path of CREATE INDEX CONCURRENTLY already
    complains about that, but if a REINDEX is issued then then the error
    generated is confusing.
    
    While on it, add more tests to check restrictions on catalog indexes and
    on toast table/index for catalogs.  Some error messages are improved,
    with wording suggestion coming from Tom Lane.
    
    Reported-by: Tom Lane
    Author: Michael Paquier
    Reviewed-by: Tom Lane
    Discussion: https://postgr.es/m/23694.1556806002@sss.pgh.pa.us
    508300e2
create_index.sql 33.2 KB