• Michael Paquier's avatar
    Reorder superuser check in pg_log_backend_memory_contexts() · 4e47b028
    Michael Paquier authored
    The use of this function is limited to superusers and the code includes
    a hardcoded check for that.  However, the code would look for the PGPROC
    entry to signal for the memory dump before checking if the user is a
    superuser or not, which does not make sense if we know that an error
    will be returned.  Note that the code would let one know if a process
    was a PostgreSQL process or not even for non-authorized users, which is
    not the case now, but this avoids taking ProcArrayLock that will most
    likely finish by being unnecessary.
    
    Thanks to Julien Rouhaud and Tom Lane for the discussion.
    
    Discussion: https://postgr.es/m/YLxw1uVGIAP5uMPl@paquier.xyz
    4e47b028
mcxtfuncs.c 6.08 KB