• Tom Lane's avatar
    Fix hash_search to avoid corruption of the hash table on out-of-memory. · 4e32f8cd
    Tom Lane authored
    An out-of-memory error during expand_table() on a palloc-based hash table
    would leave a partially-initialized entry in the table.  This would not be
    harmful for transient hash tables, since they'd get thrown away anyway at
    transaction abort.  But for long-lived hash tables, such as the relcache
    hash, this would effectively corrupt the table, leading to crash or other
    misbehavior later.
    
    To fix, rearrange the order of operations so that table enlargement is
    attempted before we insert a new entry, rather than after adding it
    to the hash table.
    
    Problem discovered by Hitoshi Harada, though this is a bit different
    from his proposed patch.
    4e32f8cd
dynahash.c 43.4 KB