• Tom Lane's avatar
    Try to improve readability of recovery/t/009_twophase.pl test. · 4e15387d
    Tom Lane authored
    The original coding here was very confusing, because it named the
    two servers it set up "master" and "slave" even though it swapped
    their replication roles multiple times.  At any given point in the
    script it was very unobvious whether "$node_master" actually referred
    to the server named "master" or the other one.  Instead, pick arbitrary
    names for the two servers --- I used "london" and "paris" --- and
    distinguish those permanent names from the nonce references $cur_master
    and $cur_slave.  Add logging to help distinguish which is which at
    any given point.  Also, use distinct data and transaction names to
    make all the prepared transactions easily distinguishable in the
    postmaster logs.  (There was one place where we intentionally tested
    that the server could cope with re-use of a transaction name, but
    it seems like one place is sufficient for that purpose.)
    
    Also, add checks at the end to make sure that all the transactions
    that were supposed to be committed did survive.
    
    Discussion: https://postgr.es/m/28238.1499010855@sss.pgh.pa.us
    4e15387d
009_twophase.pl 13.2 KB