• Tom Lane's avatar
    Restructure polymorphic-type resolution in funcapi.c. · 4dbcb3f8
    Tom Lane authored
    resolve_polymorphic_tupdesc() and resolve_polymorphic_argtypes() failed to
    cover the case of having to resolve anyarray given only an anyrange input.
    The bug was masked if anyelement was also used (as either input or
    output), which probably helps account for our not having noticed.
    
    While looking at this I noticed that resolve_generic_type() would produce
    the wrong answer if asked to make that same resolution.  ISTM that
    resolve_generic_type() is confusingly defined and overly complex, so
    rather than fix it, let's just make funcapi.c do the specific lookups
    it requires for itself.
    
    With this change, resolve_generic_type() is not used anywhere, so remove
    it in HEAD.  In the back branches, leave it alone (complete with bug)
    just in case any external code is using it.
    
    While we're here, make some other refactoring adjustments in funcapi.c
    with an eye to upcoming future expansion of the set of polymorphic types:
    
    * Simplify quick-exit tests by adding an overall have_polymorphic_result
    flag.  This is about a wash now but will be a win when there are more
    flags.
    
    * Reduce duplication of code between resolve_polymorphic_tupdesc() and
    resolve_polymorphic_argtypes().
    
    * Don't bother to validate correct matching of anynonarray or anyenum;
    the parser should have done that, and even if it didn't, just doing
    "return false" here would lead to a very confusing, off-point error
    message.  (Really, "return false" in these two functions should only
    occur if the call_expr isn't supplied or we can't obtain data type
    info from it.)
    
    * For the same reason, throw an elog rather than "return false" if
    we fail to resolve a polymorphic type.
    
    The bug's been there since we added anyrange, so back-patch to
    all supported branches.
    
    Discussion: https://postgr.es/m/6093.1584202130@sss.pgh.pa.us
    4dbcb3f8
funcapi.c 45.1 KB