• Tom Lane's avatar
    Flag index metapages as standard-format in xlog.c calls. · 4c11d2c5
    Tom Lane authored
    btree, hash, and bloom indexes all set up their metapages in standard
    format (that is, with pd_lower and pd_upper correctly delimiting the
    unused area); but they mostly didn't inform the xlog routines of this.
    When calling log_newpage[_buffer], this is bad because it loses the
    opportunity to compress unused data out of the WAL record.  When
    calling XLogRegisterBuffer, it's not such a performance problem because
    all of these call sites also use REGBUF_WILL_INIT, preventing an FPI
    image from being written.  But it's still a good idea to provide the
    flag when relevant, because that aids WAL consistency checking.
    
    This completes the project of getting all the in-core index AMs to
    handle their metapage WAL operations similarly.
    
    Amit Kapila, reviewed by Michael Paquier
    
    Discussion: https://postgr.es/m/0d273805-0e9e-ec1a-cb84-d4da400b8f85@lab.ntt.co.jp
    4c11d2c5
nbtinsert.c 68.8 KB