• Michael Paquier's avatar
    Remove redundant memset(0) calls for page init of some index AMs · 4c0239cb
    Michael Paquier authored
    Bloom, GIN, GiST and SP-GiST rely on PageInit() to initialize the
    contents of a page, and this routine fills entirely a page with zeros
    for a size of BLCKSZ, including the special space.  Those index AMs have
    been using an extra memset() call to fill with zeros the special page
    space, or even the whole page, which is not necessary as PageInit()
    already does this work, so let's remove them.  GiST was not doing this
    extra call, but has commented out a system call that did so since
    62369911.
    
    While on it, remove one MAXALIGN() for SP-GiST as PageInit() takes care
    of that.  This makes the whole page initialization logic more consistent
    across all index AMs.
    
    Author: Bharath Rupireddy
    Reviewed-by: Vignesh C, Mahendra Singh Thalor
    Discussion: https://postgr.es/m/CALj2ACViOo2qyaPT7krWm4LRyRTw9kOXt+g6PfNmYuGA=YHj9A@mail.gmail.com
    4c0239cb
spgutils.c 36.4 KB