• Michael Paquier's avatar
    Remove assertion for replication origins in PREPARE TRANSACTION · 4be3e005
    Michael Paquier authored
    When using replication origins, pg_replication_origin_xact_setup() is an
    optional choice to be able to set a LSN and a timestamp to mark the
    origin, which would be additionally added to WAL for transaction commits
    or aborts (including 2PC transactions).  An assertion in the code path
    of PREPARE TRANSACTION assumed that this data should always be set, so
    it would trigger when using replication origins without setting up an
    origin LSN.  Some tests are added to cover more this kind of scenario.
    
    Oversight in commit 1eb6d652.
    
    Per discussion with Amit Kapila and Masahiko Sawada.
    
    Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz
    Backpatch-through: 11
    4be3e005
replorigin.sql 5.47 KB