• Tom Lane's avatar
    Code review for commands/statscmds.c. · 4b34624d
    Tom Lane authored
    Fix machine-dependent sorting of column numbers.  (Odd behavior
    would only materialize for column numbers above 255, but that's
    certainly legal.)
    
    Fix poor choice of SQLSTATE for some errors, and improve error message
    wording.  (Notably, "is not a scalar type" is a totally misleading way
    to explain "does not have a default btree opclass".)
    
    Avoid taking AccessExclusiveLock on the associated relation during DROP
    STATISTICS.  That's neither necessary nor desirable, and it could easily
    have put us into situations where DROP fails (compare commit 68ea2b7f).
    
    Adjust/improve comments.
    
    David Rowley and Tom Lane
    
    Discussion: https://postgr.es/m/CAKJS1f-GmCfPvBbAEaM5xoVOaYdVgVN1gicALSoYQ77z-+vLbw@mail.gmail.com
    4b34624d
stats_ext.out 15.3 KB