• Peter Geoghegan's avatar
    Remove obsolete nbtree insertion comment. · 489e431b
    Peter Geoghegan authored
    Remove a Berkeley-era comment above _bt_insertonpg() that admonishes the
    reader to grok Lehman and Yao's paper before making any changes.  This
    made a certain amount of sense back when _bt_insertonpg() was
    responsible for most of the things that are now spread across
    _bt_insertonpg(), _bt_findinsertloc(), _bt_insert_parent(), and
    _bt_split(), but it doesn't work like that anymore.
    
    I believe that this comment alludes to the need to "couple" or "crab"
    buffer locks as we ascend the tree as page splits cascade upwards.  The
    nbtree README already explains this in detail, which seems sufficient.
    Besides, the changes to page splits made by commit 40dae7ec altered
    the exact details of how buffer locks are retained during splits; Lehman
    and Yao's original algorithm seems to release the lock on the left child
    page/buffer slightly earlier than _bt_insertonpg()/_bt_insert_parent()
    can.
    489e431b
nbtinsert.c 74.8 KB