• Andres Freund's avatar
    Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms. · 47c71879
    Andres Freund authored
    Previously we used pg_atomic_write_64_impl inside
    pg_atomic_init_u64. That works correctly, but on platforms without
    64bit single copy atomicity it could trigger spurious valgrind errors
    about uninitialized memory, because we use compare_and_swap for atomic
    writes on such platforms.
    
    I previously suppressed one instance of this problem (6c878edc),
    but as Tom reports that wasn't enough. As the atomic variable cannot
    yet be concurrently accessible during initialization, it seems better
    to have pg_atomic_init_64_impl set the value directly.
    
    Change pg_atomic_init_u32_impl for symmetry.
    
    Reported-By: Tom Lane
    Author: Andres Freund
    Discussion: https://postgr.es/m/1714601.1591503815@sss.pgh.pa.us
    Backpatch: 9.5-
    47c71879
valgrind.supp 3.41 KB