• Neil Conway's avatar
    GCC 4.0 includes a new warning option, -Wformat-literal, that emits · 47458f8c
    Neil Conway authored
    a warning when a variable is used as a format string for printf()
    and similar functions (if the variable is derived from untrusted
    data, it could include unexpected formatting sequences). This
    emits too many warnings to be enabled by default, but it does
    flag a few dubious constructs in the Postgres tree. This patch
    fixes up the obvious variants: functions that are passed a variable
    format string but no additional arguments.
    
    Most of these are harmless (e.g. the ruleutils stuff), but there
    is at least one actual bug here: if you create a trigger named
    "%sfoo", pg_dump will read uninitialized memory and fail to dump
    the trigger correctly.
    47458f8c
initdb.c 60.4 KB