• Peter Geoghegan's avatar
    Mark buffers as defined to Valgrind consistently. · 46ef520b
    Peter Geoghegan authored
    Make PinBuffer() mark buffers as defined to Valgrind unconditionally,
    including when the buffer header spinlock must be acquired.  Failure to
    handle that case could lead to false positive reports from Valgrind.
    
    This theoretically creates a risk that we'll mark buffers defined even
    when external callers don't end up with a buffer pin.  That seems
    perfectly acceptable, though, since in general we make no guarantees
    about buffers that are unsafe to access being reliably marked as unsafe.
    
    Oversight in commit 1e0dfd16, which added valgrind buffer access
    instrumentation.
    46ef520b
bufmgr.c 130 KB