• Tom Lane's avatar
    Fix planning of SELECT FOR UPDATE on child table with partial index. · 462bd957
    Tom Lane authored
    Ordinarily we can omit checking of a WHERE condition that matches a partial
    index's condition, when we are using an indexscan on that partial index.
    However, in SELECT FOR UPDATE we must include the "redundant" filter
    condition in the plan so that it gets checked properly in an EvalPlanQual
    recheck.  The planner got this mostly right, but improperly omitted the
    filter condition if the index in question was on an inheritance child
    table.  In READ COMMITTED mode, this could result in incorrectly returning
    just-updated rows that no longer satisfy the filter condition.
    
    The cause of the error is using get_parse_rowmark() when get_plan_rowmark()
    is what should be used during planning.  In 9.3 and up, also fix the same
    mistake in contrib/postgres_fdw.  It's currently harmless there (for lack
    of inheritance support) but wrong is wrong, and the incorrect code might
    get copied to someplace where it's more significant.
    
    Report and fix by Kyotaro Horiguchi.  Back-patch to all supported branches.
    462bd957
postgres_fdw.c 86.1 KB