• Tom Lane's avatar
    Improve div_var_fast(), mostly by making comments better. · 46166197
    Tom Lane authored
    The integer overflow situation in div_var_fast() is a great deal more
    complicated than the pre-existing comments would suggest.  Moreover, the
    comments were also flat out incorrect as to the precise statement of the
    maxdiv loop invariant.  Upon clarifying that, it becomes apparent that the
    way in which we updated maxdiv after a carry propagation pass was overly
    slow, complex, and conservative: we can just reset it to one, which is much
    easier and also reduces the number of times carry propagation occurs.
    Fix that and improve the relevant comments.
    
    Since this is mostly a comment fix, with only a rather marginal performance
    boost, no need for back-patch.
    
    Tom Lane and Dean Rasheed
    46166197
numeric.c 186 KB