• Tom Lane's avatar
    Fix jsonb Unicode escape processing, and in consequence disallow \u0000. · 451d2808
    Tom Lane authored
    We've been trying to support \u0000 in JSON values since commit
    78ed8e03, and have introduced increasingly worse hacks to try to
    make it work, such as commit 0ad1a816.  However, it fundamentally
    can't work in the way envisioned, because the stored representation looks
    the same as for \\u0000 which is not the same thing at all.  It's also
    entirely bogus to output \u0000 when de-escaped output is called for.
    
    The right way to do this would be to store an actual 0x00 byte, and then
    throw error only if asked to produce de-escaped textual output.  However,
    getting to that point seems likely to take considerable work and may well
    never be practical in the 9.4.x series.
    
    To preserve our options for better behavior while getting rid of the nasty
    side-effects of 0ad1a816, revert that commit in toto and instead
    throw error if \u0000 is used in a context where it needs to be de-escaped.
    (These are the same contexts where non-ASCII Unicode escapes throw error
    if the database encoding isn't UTF8, so this behavior is by no means
    without precedent.)
    
    In passing, make both the \u0000 case and the non-ASCII Unicode case report
    ERRCODE_UNTRANSLATABLE_CHARACTER / "unsupported Unicode escape sequence"
    rather than claiming there's something wrong with the input syntax.
    
    Back-patch to 9.4, where we have to do something because 0ad1a816
    broke things for many cases having nothing to do with \u0000.  9.3 also has
    bogus behavior, but only for that specific escape value, so given the lack
    of field complaints it seems better to leave 9.3 alone.
    451d2808
release-9.4.sgml 70.1 KB