• Tom Lane's avatar
    Fix aboriginal mistake in lazy VACUUM's code for truncating away · 43b0c918
    Tom Lane authored
    no-longer-needed pages at the end of a table.  We thought we could throw away
    pages containing HEAPTUPLE_DEAD tuples; but this is not so, because such
    tuples very likely have index entries pointing at them, and we wouldn't have
    removed the index entries.  The problem only emerges in a somewhat unlikely
    race condition: the dead tuples have to have been inserted by a transaction
    that later aborted, and this has to have happened between VACUUM's initial
    scan of the page and then rechecking it for empty in count_nondeletable_pages.
    But that timespan will include an index-cleaning pass, so it's not all that
    hard to hit.  This seems to explain a couple of previously unsolved bug
    reports.
    43b0c918
vacuumlazy.c 34.6 KB