• Peter Eisentraut's avatar
    Don't cast between GinNullCategory and bool · 43803626
    Peter Eisentraut authored
    The original idea was that we could use an isNull-style bool array
    directly as a GinNullCategory array.  However, the existing code already
    acknowledges that that doesn't really work, because of the possibility
    that bool as currently defined can have arbitrary bit patterns for true
    values.  So it has to loop through the nullFlags array to set each bool
    value to an acceptable value.  But if we are looping through the whole
    array anyway, we might as well build a proper GinNullCategory array
    instead and abandon the type casting.  That makes the code much safer in
    case bool is ever changed to something else.
    Reviewed-by: default avatarMichael Paquier <michael.paquier@gmail.com>
    43803626
ginblock.h 13.2 KB