• Tom Lane's avatar
    Remove useless pfree()s at the ends of various ValuePerCall SRFs. · 41b45576
    Tom Lane authored
    We don't need to manually clean up allocations in a SRF's
    multi_call_memory_ctx, because the SRF_RETURN_DONE infrastructure
    takes care of that (and also ensures that it will happen even if the
    function never gets a final call, which simple manual cleanup cannot
    do).
    
    Hence, the code removed by this patch is a waste of code and cycles.
    Worse, it gives the impression that cleaning up manually is a thing,
    which can lead to more serious errors such as those fixed in
    commits 085b6b66 and b4570d33.  So we should get rid of it.
    
    These are not quite actual bugs though, so I couldn't muster the
    enthusiasm to back-patch.  Fix in HEAD only.
    
    Justin Pryzby
    
    Discussion: https://postgr.es/m/20200308173103.GC1357@telsasoft.com
    41b45576
multixact.c 110 KB