• Peter Eisentraut's avatar
    Fix compiler warnings on 64-bit Windows · 3f9c1697
    Peter Eisentraut authored
    GCC reports various instances of
    
    warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    
    and MSVC equivalently
    
    warning C4312: 'type cast': conversion from 'int' to 'void *' of greater size
    warning C4311: 'type cast': pointer truncation from 'void *' to 'long'
    
    in ECPG test files.  This is because void* and long are cast back and
    forth, but on 64-bit Windows, these have different sizes.  Fix by
    using intptr_t instead.
    
    The code actually worked fine because the integer values in use are
    all small.  So this is just to get the test code to compile warning-free.
    
    This change is simplified by having made stdint.h required (commit
    95733841).  Before this it would have
    been more complicated because the ecpg test source files don't use the
    full pg_config.h.
    Reviewed-by: default avatarTom Lane <tgl@sss.pgh.pa.us>
    Discussion: https://www.postgresql.org/message-id/flat/5d398bbb-262a-5fed-d839-d0e5cff3c0d7%402ndquadrant.com
    3f9c1697
thread-thread_implicit.c 5.23 KB