• Heikki Linnakangas's avatar
    Fix ReadRecentBuffer for local buffers. · 3f968b94
    Heikki Linnakangas authored
    It incorrectly used GetBufferDescriptor instead of
    GetLocalBufferDescriptor, causing it to not find the correct buffer in
    most cases, and performing an out-of-bounds memory read in the corner
    case that temp_buffers > shared_buffers.
    
    It also bumped the usage-count on the buffer, even if it was
    previously pinned. That won't lead to crashes or incorrect results,
    but it's different from what the shared-buffer case does, and
    different from the usual code in LocalBufferAlloc. Fix that too, and
    make the code ordering match LocalBufferAlloc() more closely, so that
    it's easier to verify that it's doing the same thing.
    
    Currently, ReadRecentBuffer() is only used with non-temp relations, in
    WAL redo, so the broken code is currently dead code. However, it could
    be used by extensions.
    
    Backpatch-through: 14
    Discussion: https://www.postgresql.org/message-id/2d74b46f-27c9-fb31-7f99-327a87184cc0%40iki.fi
    Reviewed-by: Thomas Munro, Zhang Mingli, Richard Guo
    3f968b94
bufmgr.c 139 KB