• Tom Lane's avatar
    Fix EXPLAIN (SETTINGS) to follow policy about when to print empty fields. · 3ec20c70
    Tom Lane authored
    In non-TEXT output formats, the "Settings" field should appear when
    requested, even if it would be empty.
    
    Also, get rid of the premature optimization of counting all the
    GUC_EXPLAIN variables at startup.  Since there was no provision for
    adjusting that count later, all it'd take would be some extension marking
    a parameter as GUC_EXPLAIN to risk an assertion failure or memory stomp.
    We could make get_explain_guc_options() count those variables on-the-fly,
    or dynamically resize its array ... but TBH I do not think that making a
    transient array of pointers a bit smaller is worth any extra complication,
    especially when you consider all the other transient space EXPLAIN eats.
    So just allocate that array at the max possible size.
    
    In HEAD, also add some regression test coverage for this feature.
    
    Because of the memory-stomp hazard, back-patch to v12 where this
    feature was added.
    
    Discussion: https://postgr.es/m/19416.1580069629@sss.pgh.pa.us
    3ec20c70
guc.c 306 KB