• Andrew Dunstan's avatar
    Allow TestLib::slurp_file to skip contents, and use as needed · 3c5b0685
    Andrew Dunstan authored
    In order to avoid getting old logfile contents certain functions in
    PostgresNode were doing one of two things. On Windows it rotated the
    logfile and restarted the server, while elsewhere it truncated the log
    file. Both of these are unnecessary. We borrow from the buildfarm which
    does this instead: note the size of the logfile before we start, and
    then when fetching the logfile skip to that position before accumulating
    contents. This is spelled differently on Windows but the effect is the
    same. This is largely centralized in TestLib's slurp_file function,
    which has a new optional parameter, the offset to skip to before
    starting to reading the file. Code in the client becomes much neater.
    
    Backpatch to all live branches.
    
    Michael Paquier, slightly modified by me.
    
    Discussion: https://postgr.es/m/YHajnhcMAI3++pJL@paquier.xyz
    3c5b0685
TestLib.pm 19.6 KB