• Tom Lane's avatar
    Fix gist_box_same and gist_point_consistent to handle fuzziness correctly. · 3c29b196
    Tom Lane authored
    While there's considerable doubt that we want fuzzy behavior in the
    geometric operators at all (let alone as currently implemented), nobody is
    stepping forward to redesign that stuff.  In the meantime it behooves us
    to make sure that index searches agree with the behavior of the underlying
    operators.  This patch fixes two problems in this area.
    
    First, gist_box_same was using fuzzy equality, but it really needs to use
    exact equality to prevent not-quite-identical upper index keys from being
    treated as identical, which for example would prevent an existing upper
    key from being extended by an amount less than epsilon.  This would result
    in inconsistent indexes.  (The next release notes will need to recommend
    that users reindex GiST indexes on boxes, polygons, circles, and points,
    since all four opclasses use gist_box_same.)
    
    Second, gist_point_consistent used exact comparisons for upper-page
    comparisons in ~= searches, when it needs to use fuzzy comparisons to
    ensure it finds all matches; and it used fuzzy comparisons for point <@ box
    searches, when it needs to use exact comparisons because that's what the
    <@ operator (rather inconsistently) does.
    
    The added regression test cases illustrate all three misbehaviors.
    
    Back-patch to all active branches.  (8.4 did not have GiST point_ops,
    but it still seems prudent to apply the gist_box_same patch to it.)
    
    Alexander Korotkov, reviewed by Noah Misch
    3c29b196
point.out 9.51 KB