• Heikki Linnakangas's avatar
    Simplify the way changes to full_page_writes are logged. · 3b682df3
    Heikki Linnakangas authored
    It's harmless to do full page writes even when not strictly necessary, so
    when turning full_page_writes on, we can set the global flag first, and then
    call XLogInsert. Likewise, when turning it off, we can write the WAL record
    first, and then clear the flag. This way XLogInsert doesn't need any special
    handling of the XLOG_FPW_CHANGE record type. XLogInsert is complicated
    enough already, so anything we can keep away from there is a good thing.
    
    Actually I don't think the atomicity of the shared memory flag matters,
    anyway, because we only write the XLOG_FPW_CHANGE at the end of recovery,
    when there are no concurrent WAL insertions going on. But might as well make
    it safe, in case we allow changing full_page_writes on the fly in the
    future.
    3b682df3
xlog.c 315 KB