• Tom Lane's avatar
    Avoid logging complaints about abandoned connections when using PAM. · 3affe76e
    Tom Lane authored
    For a long time (since commit aed378e8) we have had a policy to log
    nothing about a connection if the client disconnects when challenged
    for a password.  This is because libpq-using clients will typically
    do that, and then come back for a new connection attempt once they've
    collected a password from their user, so that logging the abandoned
    connection attempt will just result in log spam.  However, this did
    not work well for PAM authentication: the bottom-level function
    pam_passwd_conv_proc() was on board with it, but we logged messages
    at higher levels anyway, for lack of any reporting mechanism.
    Add a flag and tweak the logic so that the case is silent, as it is
    for other password-using auth mechanisms.
    
    Per complaint from Yoann La Cancellera.  It's been like this for awhile,
    so back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/CACP=ajbrFFYUrLyJBLV8=q+eNCapa1xDEyvXhMoYrNphs-xqPw@mail.gmail.com
    3affe76e
auth.c 90.9 KB