• Peter Eisentraut's avatar
    Fix/improve bytea and boolean support in PL/Python · 3ab8b7fa
    Peter Eisentraut authored
    Before, PL/Python converted data between SQL and Python by going
    through a C string representation.  This broke for bytea in two ways:
    
    - On input (function parameters), you would get a Python string that
      contains bytea's particular external representation with backslashes
      etc., instead of a sequence of bytes, which is what you would expect
      in a Python environment.  This problem is exacerbated by the new
      bytea output format.
    
    - On output (function return value), null bytes in the Python string
      would cause truncation before the data gets stored into a bytea
      datum.
    
    This is now fixed by converting directly between the PostgreSQL datum
    and the Python representation.
    
    The required generalized infrastructure also allows for other
    improvements in passing:
    
    - When returning a boolean value, the SQL datum is now true if and
      only if Python considers the value that was passed out of the
      PL/Python function to be true.  Previously, this determination was
      left to the boolean data type input function.  So, now returning
      'foo' results in true, because Python considers it true, rather than
      false because PostgreSQL considers it false.
    
    - On input, we can convert the integer and float types directly to
      their Python equivalents without having to go through an
      intermediate string representation.
    
    original patch by Caleb Welton, with updates by myself
    3ab8b7fa
plpython.c 77.6 KB