• Marc G. Fournier's avatar
    · 3a3c1b85
    Marc G. Fournier authored
    From: Tom Lane <tgl@sss.pgh.pa.us>
    
    I see someone missed an ancient bit of shell-scripting lore:
    on some older shells, if your script's argument list is empty,
    then "$@" generates an empty-string word rather than no word
    at all.  You need to write ${1+"$@"} to get the latter behavior.
    (Read your shell man page to see exactly how that works,
    but it does the Right Thing on every Bourne shell.)
    
    In particular, pg_dumpall fails when invoked without any switches
    on HPUX 9.*, because pg_dump gets an empty-string argument that it
    thinks is the name of the database to dump.  I expect this bug
    also affects some other OSes, but couldn't tell you just which ones.
    Patch attached.
    3a3c1b85
pg_dumpall 1.62 KB