• Tom Lane's avatar
    Fix potentially-unportable code in contrib/adminpack. · 3a2d6365
    Tom Lane authored
    Spelling access(2)'s second argument as "2" is just horrid.
    POSIX makes no promises as to the numeric values of W_OK and related
    macros.  Even if it accidentally works as intended on every supported
    platform, it's still unreadable and inconsistent with adjacent code.
    
    In passing, don't spell "NULL" as "0" either.  Yes, that's legal C;
    no, it's not project style.
    
    Back-patch, just in case the unportability is real and not theoretical.
    (Most likely, even if a platform had different bit assignments for
    access()'s modes, there'd not be an observable behavior difference
    here; but I'm being paranoid today.)
    3a2d6365
adminpack.c 13.5 KB