• Tom Lane's avatar
    Rearrange logrep worker's snapshot handling some more. · 3a09d75b
    Tom Lane authored
    It turns out that worker.c's code path for TRUNCATE was also
    careless about establishing a snapshot while executing user-defined
    code, allowing the checks added by commit 84f5c290 to fail when
    a trigger is fired in that context.
    
    We could just wrap Push/PopActiveSnapshot around the truncate call,
    but it seems better to establish a policy of holding a snapshot
    throughout execution of a replication step.  To help with that and
    possible future requirements, replace the previous ensure_transaction
    calls with pairs of begin/end_replication_step calls.
    
    Per report from Mark Dilger.  Back-patch to v11, like the previous
    changes.
    
    Discussion: https://postgr.es/m/B4A3AF82-79ED-4F4C-A4E5-CD2622098972@enterprisedb.com
    3a09d75b
worker.c 86.4 KB