• Robert Haas's avatar
    Fix toast table creation. · 39a68e5c
    Robert Haas authored
    Instead of using slightly-too-clever heuristics to decide when we must
    create a TOAST table, just check whether one is needed every time the
    table is altered.  Checking whether a toast table is needed is cheap
    enough that we needn't worry about doing it on every ALTER TABLE command,
    and the previous coding is apparently prone to accidental breakage:
    commit 04e17bae broken ALTER TABLE ..
    SET STORAGE, which moved some actions from AT_PASS_COL_ATTRS to
    AT_PASS_MISC, and commit 6c572399 broke
    ALTER TABLE .. ADD COLUMN by changing the way that adding columns
    recurses into child tables.
    
    Noah Misch, with one comment change by me
    39a68e5c
alter_table.sql 42 KB