• Tom Lane's avatar
    Partially revert commit 3d3bf62f. · 391159e0
    Tom Lane authored
    On reflection, the pre-existing logic in ANALYZE is specifically meant to
    compare the frequency of a candidate MCV against the estimated frequency of
    a random distinct value across the whole table.  The change to compare it
    against the average frequency of values actually seen in the sample doesn't
    seem very principled, and if anything it would make us less likely not more
    likely to consider a value an MCV.  So revert that, but keep the aspect of
    considering only nonnull values, which definitely is correct.
    
    In passing, rename the local variables in these stanzas to
    "ndistinct_table", to avoid confusion with the "ndistinct" that appears at
    an outer scope in compute_scalar_stats.
    391159e0
analyze.c 81.3 KB