• Tom Lane's avatar
    Fix pg_dump's logic for eliding sequence limits that match the defaults. · 3486bcf9
    Tom Lane authored
    The previous coding here applied atoi() to strings that could represent
    values too large to fit in an int.  If the overflowed value happened to
    match one of the cases it was looking for, it would drop that limit
    value from the output, leading to incorrect restoration of the sequence.
    
    Avoid the unsafe behavior, and also make the logic cleaner by explicitly
    calculating the default min/max values for the appropriate kind of
    sequence.
    
    Reported and patched by Alexey Bashtanov, though I whacked his patch
    around a bit.  Back-patch to v10 where the faulty logic was added.
    
    Discussion: https://postgr.es/m/cb85a9a5-946b-c7c4-9cf2-6cd6e25d7a33@imap.cc
    3486bcf9
pg_dump.c 551 KB